[asterisk-dev] [Code Review] 3329: AGI Exit Status Test

[Benjamin Keith Ford]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3329/
-----------------------------------------------------------

(Updated March 14, 2014, 2:43 p.m.)


Review request for Asterisk Developers.


Changes
-------

- Added a result:fail for UserEvents
- Fixed grammar errors
- Changed "detected" variable to "interrupt_agi"
- Updated some if/else statements
- Fixed syntax errors
- Added a constant EXPECTED_SUCCESSES to be easily modified if the test needs to be updated
- Added an expected versus actual success count if the test failed


Bugs: ASTERISK-19167
    https://issues.asterisk.org/jira/browse/ASTERISK-19167


Repository: testsuite


Description
-------

Notes:
- Is a sub-task of ASTERISK-19167
- Ignore userA directory; will be removed from repository

This test runs through a few different AGI scripts to verify that AGISTATUS returns the correct values:
1. Attempts to run an AGI script that does not exist. AGISTATUS returns NOTFOUND.
2. Attempts to run an AGI script that has an invalid path. AGISTATUS returns FAILURE.
3. Attempts to run an AGI script that has a non-executable interpreter. AGISTATUS returns FAILURE.
4. Attempts to run an AGI script that is non-executable. AGISTATUS returns FAILURE.
5. Runs an AGI script that will be hung up on while waiting for a command. AGISTATUS returns HANGUP.
6. Runs an AGI script that will be hung up on while executing a command. AGISTATUS returns HANGUP.
7. Runs an AGI script that exits normally. AGISTATUS returns SUCCESS.


Diffs (updated)
-----

  ./asterisk/trunk/tests/agi/exit_status/waiting.agi PRE-CREATION 
  ./asterisk/trunk/tests/agi/exit_status/test-config.yaml 4749 
  ./asterisk/trunk/tests/agi/exit_status/run-test 4749 
  ./asterisk/trunk/tests/agi/exit_status/executing.agi PRE-CREATION 
  ./asterisk/trunk/tests/agi/exit_status/donothing.agi PRE-CREATION 
  ./asterisk/trunk/tests/agi/exit_status/configs/ast1/extensions.conf PRE-CREATION 
  ./asterisk/trunk/tests/agi/exit_status/badinterpreter3.agi PRE-CREATION 
  ./asterisk/trunk/tests/agi/exit_status/badinterpreter2.agi PRE-CREATION 
  ./asterisk/trunk/tests/agi/exit_status/badinterpreter.agi PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3329/diff/


Testing
-------


Thanks,

Benjamin Keith Ford

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140314/23d053b4/attachment.html>