[asterisk-dev] [Code Review] 3322: media_formats: Move resource modules over.

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3322/#review11189
-----------------------------------------------------------



/team/group/media_formats-reviewed/res/res_musiconhold.c
<https://reviewboard.asterisk.org/r/3322/#comment20827>

    I think there is a chance of a leak here.  origwfmt is not NULL and if mohwfmt is NULL then origwfmt doesn't get its ref count decremented before being overwritten.


- Kevin Harwell


On March 8, 2014, 11:36 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3322/
> -----------------------------------------------------------
> 
> (Updated March 8, 2014, 11:36 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This moves the resource modules over to the new media formats API.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed/res/res_stasis_snoop.c 409286 
>   /team/group/media_formats-reviewed/res/res_stasis.c 409286 
>   /team/group/media_formats-reviewed/res/res_speech.c 409286 
>   /team/group/media_formats-reviewed/res/res_musiconhold.c 409286 
>   /team/group/media_formats-reviewed/res/res_fax_spandsp.c 409286 
>   /team/group/media_formats-reviewed/res/res_fax.c 410186 
>   /team/group/media_formats-reviewed/res/res_clioriginate.c 409286 
>   /team/group/media_formats-reviewed/res/res_calendar.c 409286 
>   /team/group/media_formats-reviewed/res/res_agi.c 409286 
>   /team/group/media_formats-reviewed/res/res_adsi.c 409286 
>   /team/group/media_formats-reviewed/res/parking/parking_applications.c 409286 
>   /team/group/media_formats-reviewed/res/ari/resource_sounds.c 409286 
>   /team/group/media_formats-reviewed/res/ari/resource_channels.c 409286 
>   /team/group/media_formats-reviewed/res/ari/resource_bridges.c 409286 
> 
> Diff: https://reviewboard.asterisk.org/r/3322/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140313/8bb32ea1/attachment.html>