[asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

[Jonathan Rose]

> On March 13, 2014, 7:32 a.m., Joshua Colp wrote:
> > /branches/12/res/res_pjsip/config_transport.c, lines 505-518
> > <https://reviewboard.asterisk.org/r/3324/diff/1/?file=55753#file55753line505>
> >
> >     Why not just use ast_asprintf for both of the to_str functions?

Because... sometimes I forget which string functions exist in which languages and which ones we have handlers for in our memory manager.
In short, >_<


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3324/#review11164
-----------------------------------------------------------


On March 10, 2014, 2:04 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3324/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 2:04 p.m.)
> 
> 
> Review request for Asterisk Developers, George Joseph and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23235
>     https://issues.asterisk.org/jira/browse/ASTERISK-23235
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> ToS values were showing up as strings in the output for the sorcery objects of res_pjsip endpoints and transports. This was causing test failures at one time and is also just not a very useful way of using TOS values that aren't from the predefined ToS names.  I also added a chart of named ToS values and their decimal equivalents to https://wiki.asterisk.org/wiki/display/AST/IP+Quality+of+Service This patch makes it so that they are output as decimal values only in the sorcery objects.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/pjsip_configuration.c 410367 
>   /branches/12/res/res_pjsip/config_transport.c 410367 
>   /branches/12/main/acl.c 410367 
>   /branches/12/include/asterisk/acl.h 410367 
>   /branches/12/CHANGES 410367 
> 
> Diff: https://reviewboard.asterisk.org/r/3324/diff/
> 
> 
> Testing
> -------
> 
> Tested output for all the named ToS values and some values without equivalents.  Tested values above 255... since it uses the str2tos function, this has a sort of wrap around behavior for anything above 255. Not sure how appropriate that is, but it's been in place historically anyway. Updated tests that were evaluating PJSIP tos settings.  That's in another review.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140313/1ed4cd8f/attachment-0001.html>