[asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3306/
-----------------------------------------------------------

(Updated March 6, 2014, 5:59 p.m.)


Review request for Asterisk Developers.


Changes
-------

* Made res_musiconhold.c always post the MusicOnHoldStart/MusicOnHoldStop events when it actually starts/stops the music streams.  This allows the events to always happen when MOH starts/stops.  The event posting code was moved to the MOH alloc/release routines.

* Made channel_do_masquerade() stop any MOH on the original channel before masquerading so the original channel will get a stop event with correct information.

* Cleaned up a couple odd codings in moh_files_alloc() and moh_alloc() dealing with the music state variable.


Bugs: ASTERISK-23311
    https://issues.asterisk.org/jira/browse/ASTERISK-23311


Repository: Asterisk


Description
-------

When MOH is playing to a user in a conference and the user is kicked or hangs up from the conference then the AMI MusicOnHoldSotp events didn't happen.

This patch should be done for v11+.


Diffs (updated)
-----

  /branches/12/res/res_musiconhold.c 410092 
  /branches/12/main/channel.c 410092 
  /branches/12/apps/confbridge/conf_state_single_marked.c 410092 
  /branches/12/apps/confbridge/conf_state_single.c 410092 
  /branches/12/apps/confbridge/conf_state_inactive.c 410092 
  /branches/12/apps/confbridge/conf_state.c 410092 

Diff: https://reviewboard.asterisk.org/r/3306/diff/


Testing
-------

Before patch the AMI MusicOnHoldStop event did not happen when the user is kicked or hangs up to leave the conference.
With the patch the event happens.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140306/3080b743/attachment-0001.html>