[asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3283/
-----------------------------------------------------------

(Updated March 6, 2014, 2:51 p.m.)


Review request for Asterisk Developers.


Changes
-------

Added documentation to the new structures.
Removed unused members from structures.
Backed out the extended attributes and created a wrapper structure for contact.
Fixed some pre-existing reference leaks.
Ran refcounter to check for leaks during cli commands.


Bugs: ASTERISK-23276
    https://issues.asterisk.org/jira/browse/ASTERISK-23276


Repository: Asterisk


Description
-------

Created the 'pjsip show channel' and 'pjsip show contact' commands.
Refactored out the hated ast_hashtab.  Replaced with ao2_container.
Cleaned up function naming.  Internal only, no public name changes.
Cleaned up whitespace and brace formatting in cli code.
Changed some NULL checking from "if"s to ast_asserts.
Fixed some register/unregister ordering to reduce deadlock potential.
Fixed a bug in ast_sip_location_add_contact where the 'name' buffer was too short.
Fixed some self-assignment issues in res_pjsip_outbound_registration related to AMI.


Diffs (updated)
-----

  branches/12/res/res_pjsip_outbound_registration.c 410041 
  branches/12/res/res_pjsip_endpoint_identifier_ip.c 410041 
  branches/12/res/res_pjsip/pjsip_configuration.c 410041 
  branches/12/res/res_pjsip/pjsip_cli.c 410041 
  branches/12/res/res_pjsip/location.c 410041 
  branches/12/res/res_pjsip/config_transport.c 410041 
  branches/12/res/res_pjsip/config_auth.c 410041 
  branches/12/main/sorcery.c 410041 
  branches/12/include/asterisk/sorcery.h 410041 
  branches/12/include/asterisk/res_pjsip_cli.h 410041 
  branches/12/include/asterisk/res_pjsip.h 410041 

Diff: https://reviewboard.asterisk.org/r/3283/diff/


Testing
-------

Ran all 'pjsip show' and 'pjsip list' commands to make sure the output was correct.
Ran testsuite tests/channels/pjsip/ami to make sure the AMI wasn't affected by the buffer and self-assignment fix.


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140306/4b5d4583/attachment.html>