[asterisk-dev] [Code Review] 3284: chan_sip: Fix deadlock of monlock between unload_module and do_monitor

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3284/#review11100
-----------------------------------------------------------

Ship it!


This looks good to me!

- opticron


On March 3, 2014, 1:54 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3284/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 1:54 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21406
>     https://issues.asterisk.org/jira/browse/ASTERISK-21406
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change prevents a deadlock caused by running pthread_join with monlock held in unload_module.  This ensures that if do_monitor trys to lock monlock after unload_module, it will eventually receive the lock and be allowed to exit.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 409411 
> 
> Diff: https://reviewboard.asterisk.org/r/3284/diff/
> 
> 
> Testing
> -------
> 
> Tested with chan_sip-unload-deadlock-debug.patch from ASTERISK-21406 to ensure I could no longer reproduce the deadlock.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140306/631c95a2/attachment.html>