[asterisk-dev] [Code Review] 3193: cli: pjsip show endpoint <endpoint> shows allow/disallow codecs the same (take 8)

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3193/
-----------------------------------------------------------

(Updated March 6, 2014, 9:44 a.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed review comments


Bugs: ASTERISK-23092
    https://issues.asterisk.org/jira/browse/ASTERISK-23092


Repository: Asterisk


Description
-------

WAS:

Insert a ! prefix in the display of endpoint disallow value.  Result is:

 disallow                      : !(ulaw|alaw)

NOW:

Remove the disallow option from generated lists, while still accepting it from a configuration file.

This attempt is short and sweet: add a flag to __ast_sorcery_object_field_register to indicate an 'alias' field, i.e. one that overlaps another field and is to be supported ongoing (to not break older .conf's) but has been replaced by a new field.  Both the alias and the non-alias will load from the .conf file, but only the non-alias fields are actually kept in sorcery where they "exist" to iterate through.

This approach (rather than using aco's existing deprecated option) is made necessary because the allow & disallow options make use of a flags parameter (to differentiate between the two) and this is not replicated in aco (I tried to add it in take 7 and that was no good).

In this patch, the allow & disallow are both alias'd and a new codecs field replaces them.  This is merely a suggestion and an example that could be tossed or placed only in trunk.


Diffs (updated)
-----

  /branches/12/res/res_pjsip/pjsip_configuration.c 409676 
  /branches/12/main/sorcery.c 409676 
  /branches/12/include/asterisk/sorcery.h 409676 

Diff: https://reviewboard.asterisk.org/r/3193/diff/


Testing
-------

Ran command and checked output.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140306/9a9985e6/attachment.html>