[asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

[Scott Griepentrog]

> On March 4, 2014, 4:52 p.m., Matt Jordan wrote:
> > So, we definitely need to get this in.
> > 
> > Right now, however, I'm struggling with how we can test this. Ideally, we'd have some automated test in the Asterisk Test Suite, but besides getting a build agent with some special purpose hardware, I'm not sure how we're going to go about accomplishing that.
> > 
> > Do you have any ideas?
> 
> Scott Griepentrog wrote:
>     Shouldn't it be possible to set up two transports as 127.0.0.1 and 127.0.0.2 and have sipp scenarios test each one?
> 
> Joshua Colp wrote:
>     As other tests have shown relying on that sort of behavior is haphazard and dependent on the Linux distribution itself. I'm not sure if there's a way to *reliably* test this in a simple environment.

Ah.. Okay, so how about two tests exactly alike except that you swap the IP's from 127.0.0.1 and another arbitrary value (that you don't actively test on that run).  That should be proof enough that the code is correctly discerning the difference.


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3102/#review11060
-----------------------------------------------------------


On Feb. 23, 2014, 11:57 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3102/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2014, 11:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23020
>     https://issues.asterisk.org/jira/browse/ASTERISK-23020
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This module adds messaging rewriting for multihomed situations. When messages are sent out it determines what interface and transport the message is going out on. The IP address for this is then placed into the message.
> 
> I've written this as a module since it does add a bit of additional logic for outgoing messages.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_multihomed.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3102/diff/
> 
> 
> Testing
> -------
> 
> Sent and received calls/traffic in two configurations.
> 
> 1. Two transports each bound to specific interfaces
> 2. One transport bound to 0.0.0.0
> 
> Confirmed that the correct IP address for each interface went into the message.
> 
> Some additional testing by others would be nice.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140304/3b5494d2/attachment.html>