[asterisk-dev] [Code Review] 3242: starpy: add UniqueId parameter to ami.Originate()

Paul Belanger reviewboard at asterisk.org
Tue Mar 4 13:34:13 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3242/#review11046
-----------------------------------------------------------


I suspect if you're submitting this change upstream, you'll need to do some version checks on the AMI for the API breakage.  I'm not sure what will happen when you send asterisk a parameter it doesn't know about. But we still want starpy to support 1.8, 11 as long as possible.

- Paul Belanger


On Feb. 25, 2014, 9:42 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3242/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 9:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23120
>     None
> 
> 
> Description
> -------
> 
> In order to test specifying the Unique Channel ID on ami.originate(), it must know about the parameter.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviewboard.asterisk.org/r/3242/diff/
> 
> 
> Testing
> -------
> 
> Required for https://reviewboard.asterisk.org/r/3243/
> 
> 
> File Attachments
> ----------------
> 
> Update includes otherchannelid param
>   https://reviewboard.asterisk.org/media/uploaded/files/2014/02/25/b803fe75-d355-4899-9396-66e774ed355c__starpy2.patch
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140304/550841e9/attachment-0001.html>


More information about the asterisk-dev mailing list