[asterisk-dev] [Code Review] 3268: test_conditions: pre-/post- checks cleanup

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3268/#review11010
-----------------------------------------------------------

Ship it!


- Matt Jordan


On Feb. 25, 2014, 3:27 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3268/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 3:27 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Removed pre/post checks from any testsuite test that currently contained them.  Fixed a couple of bugs that caused the testsuite to hang (exception thrown causing the twisted reactor to crash) with regards to channel pre/post checks.  Also made it so any future test wishing to utilize this functionality will have its configuration appropriately read.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/pbx/pbx_lua_goto/test-config.yaml 4732 
>   asterisk/trunk/tests/pbx/pbx_lua_background/test-config.yaml 4732 
>   asterisk/trunk/tests/masquerade/test-config.yaml 4732 
>   asterisk/trunk/tests/funcs/func_srv/test-config.yaml 4732 
>   asterisk/trunk/tests/dynamic-modules/test-config.yaml 4732 
>   asterisk/trunk/tests/channels/pjsip/message/message_send_ami/test-config.yaml 4732 
>   asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/test-config.yaml 4732 
>   asterisk/trunk/tests/channels/SIP/sip_hold/test-config.yaml 4732 
>   asterisk/trunk/tests/channels/SIP/message_send_ami/test-config.yaml 4732 
>   asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/test-config.yaml 4732 
>   asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/test-config.yaml 4732 
>   asterisk/trunk/tests/callparking/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/play_message/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/func_vmcount/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/test-config.yaml 4732 
>   asterisk/trunk/tests/apps/incomplete/sip_incomplete/test-config.yaml 4732 
>   asterisk/trunk/test-config.yaml 4732 
>   asterisk/trunk/lib/python/asterisk/test_case.py 4732 
>   asterisk/trunk/lib/python/asterisk/channel_test_condition.py 4732 
> 
> Diff: https://reviewboard.asterisk.org/r/3268/diff/
> 
> 
> Testing
> -------
> 
> Ran a test using channel pre/post checks.  Changed the number of allowed channels and watched it pass/fail.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140301/ed0db089/attachment.html>