[asterisk-dev] [Code Review] 3884: testsuite: fail sipp test if sipp not installed

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3884/#review12950
-----------------------------------------------------------



/asterisk/trunk/lib/python/asterisk/sipp.py
<https://reviewboard.asterisk.org/r/3884/#comment23334>

    I'm guessing this should go away, or be a info/debug message instead of error.


- Corey Farrell


On July 31, 2014, 3:36 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3884/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 3:36 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> If sipp is not listed as a dependency, and isn't installed, the sipp test case would lock up the testsuite run trying to kill a nonexistant process.
> 
> This change raises an exception if the sipp isn't found when initializing the sipp test case to prevent this issue.
> 
> Also, I added the dependency to the test that I got stuck on.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/user_agent/test-config.yaml 5328 
>   /asterisk/trunk/lib/python/asterisk/sipp.py 5328 
> 
> Diff: https://reviewboard.asterisk.org/r/3884/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140731/ee100ac1/attachment.html>