[asterisk-dev] [Code Review] 3865: Stasis: Handle incoming masquerades

opticron reviewboard at asterisk.org
Mon Jul 28 11:41:20 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3865/
-----------------------------------------------------------

(Updated July 28, 2014, 11:41 a.m.)


Review request for Asterisk Developers, Matt Jordan and Mark Michelson.


Changes
-------

Address Richard's comments.


Bugs: ASTERISK-23941
    https://issues.asterisk.org/jira/browse/ASTERISK-23941


Repository: Asterisk


Description
-------

This adds handling for a channel being pushed into Stasis() via masquerade. It notifies the Stasis() application using the previously established StasisStart with the "replace_channel" key populated with a channel snapshot of the channel that is being replaced. It also sets up the new channel topic forwards required to get information from the new channel and tears down the old channel topic forwards.

This patch also introduces the concept of chan_breakdown datastore callbacks which are called for the channel being masqueraded into during a masquerade.


Diffs (updated)
-----

  team/group/ari-greedy-atxfer/res/stasis/app.c 419681 
  team/group/ari-greedy-atxfer/res/stasis/app.h 419681 
  team/group/ari-greedy-atxfer/res/res_stasis.c 419681 
  team/group/ari-greedy-atxfer/main/channel.c 419681 
  team/group/ari-greedy-atxfer/include/asterisk/datastore.h 419681 

Diff: https://reviewboard.asterisk.org/r/3865/diff/


Testing
-------

Verified that the correct messages were being received by the Stasis() application monitoring the channel.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140728/1cb27f78/attachment-0001.html>


More information about the asterisk-dev mailing list