[asterisk-dev] [Code Review] 3844: features.c: Allow appliationmap to use Gosub.

[Guenther Kelleter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3844/#review12868
-----------------------------------------------------------

Ship it!


Tested with Asterisk 11:
Gosub is now working as expected.  Macro did already work before this changes and does so now.

- Guenther Kelleter


On July 23, 2014, 11:43 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3844/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 11:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1391
>     https://issues.asterisk.org/jira/browse/AST-1391
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Using DYNAMIC_FEATURES with a Gosub application as the mapped application does not work.  It does not work because Gosub just pushes the current dialplan context, exten, and priority onto a stack and sets the specified Gosub location.  Gosub does not have a dialplan execution loop to run dialplan like Macro.
> 
> * Made the DYNAMIC_FEATURES application mapping feature call ast_app_exec_macro() and ast_app_exec_sub() for the Macro and Gosub applications respectively.
> 
> * Backported ast_app_exec_macro() and ast_app_exec_sub() from v11 to execute dialplan routines from the DYNAMIC_FEATURES application mapping feature.
> 
> NOTE: This issue does not affect v12+ because it already does what this patch implements.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/features.c 419341 
>   /branches/1.8/main/app.c 419341 
>   /branches/1.8/include/asterisk/app.h 419341 
>   /branches/1.8/apps/app_stack.c 419341 
> 
> Diff: https://reviewboard.asterisk.org/r/3844/diff/
> 
> 
> Testing
> -------
> 
> Triggered DYNAMIC_FEATURES mapped to the following applications:
> Playback
> Gosub
> Macro
> 
> The Playback played the file, the Gosub and Macro applications executed their respective dialplan sections.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140725/ba0d1461/attachment.html>