[asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3819/#review12774
-----------------------------------------------------------

Ship it!



/trunk/main/bridge_channel.c
<https://reviewboard.asterisk.org/r/3819/#comment23087>

    Super pedantic nit-pick:
    
    I'd use "substituted_args" as opposed to "substitutedargs".


- Matt Jordan


On July 18, 2014, 3:51 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3819/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 3:51 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22608
>     https://issues.asterisk.org/jira/browse/ASTERISK-22608
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Say you wanted to include variables in an application map and have those variables substituted and passed along to the application being executed; currently this does not happen.
> This patch adds this new feature.
> 
> This simple patch was originally written for 1.4 but I have been maintaining it all the way up to version 11.  It is time to see if anyone else sees any value in this and get it committed.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/bridge_channel.c 418910 
>   /trunk/CHANGES 418910 
> 
> Diff: https://reviewboard.asterisk.org/r/3819/diff/
> 
> 
> Testing
> -------
> 
> This has been in production since 1.4 and updated for trunk.  The trunk version of the patch was tested on dev machine.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140721/ac480c61/attachment.html>