[asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

[Corey Farrell]

> On July 18, 2014, 12:09 p.m., opticron wrote:
> >

I'm going to run tests/channels/SIP then I'll update the diff.


> On July 18, 2014, 12:09 p.m., opticron wrote:
> > /trunk/channels/chan_sip.c, lines 1190-1194
> > <https://reviewboard.asterisk.org/r/3759/diff/2/?file=63077#file63077line1190>
> >
> >     This would be cleaner using ao2_t_bump.

I've removed registry_addref and registry_unref, and replaced with appropriate calls to ao2_t_ref, ao2_t_replace and ao2_t_bump.  Most calls to this macro were not even using the return.


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12742
-----------------------------------------------------------


On July 13, 2014, 12:48 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3759/
> -----------------------------------------------------------
> 
> (Updated July 13, 2014, 12:48 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Upgrade all ASTOBJ objects in chan_sip to ao2.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/sip/include/sip.h 418438 
>   /trunk/channels/chan_sip.c 418438 
> 
> Diff: https://reviewboard.asterisk.org/r/3759/diff/
> 
> 
> Testing
> -------
> 
> Full testsuite run.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140718/057b9664/attachment.html>