[asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3822/
-----------------------------------------------------------

(Updated July 17, 2014, 2:39 p.m.)


Review request for Asterisk Developers.


Changes
-------

Correct description for function names that were moved to channels/iax2/format_compatibility.c


Repository: Asterisk


Description (updated)
-------

* Move all ast_codec_pref functions to channels/iax2/codec_pref.c.
* Move ast_format_compatibility_cap2bitfield, ast_format_compatibility_bitfield2cap and ast_format_compatibility_bitfield2format to channels/iax2/format_compatibility.c
* Change prefix of all moved functions from ast_ to iax2_.
* Fix comment in include/asterisk/config_options.h

ast_format_compatibility_format2bitfield and ast_format_compatibility_codec2bitfield are the only functions that remain in main/format_compatibility.c as they are used by other modules.


Diffs
-----

  /team/group/media_formats-reviewed-trunk/main/format_compatibility.c 418809 
  /team/group/media_formats-reviewed-trunk/main/format_compatibility.c HEAD 
  /team/group/media_formats-reviewed-trunk/main/format_compatibility.c HEAD 
  /team/group/media_formats-reviewed-trunk/include/asterisk/format_compatibility.h 418809 
  /team/group/media_formats-reviewed-trunk/include/asterisk/format_compatibility.h HEAD 
  /team/group/media_formats-reviewed-trunk/include/asterisk/format_compatibility.h HEAD 
  /team/group/media_formats-reviewed-trunk/include/asterisk/config_options.h 418809 
  /team/group/media_formats-reviewed-trunk/channels/iax2/parser.c 418809 
  /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c 418809 

Diff: https://reviewboard.asterisk.org/r/3822/diff/


Testing
-------

Compile only.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/45e09faf/attachment.html>