[asterisk-dev] [Code Review] 3803: codec_dahdi: Fix type mismatches and other badness.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3803/#review12686
-----------------------------------------------------------



/team/group/media_formats-reviewed-trunk/codecs/codec_dahdi.c
<https://reviewboard.asterisk.org/r/3803/#comment22962>

    Not really. Shouldn't impact anything in reality.



/team/group/media_formats-reviewed-trunk/include/asterisk/format_compatibility.h
<https://reviewboard.asterisk.org/r/3803/#comment22961>

    Since these are now in a public header file it would be nice to have a comment for each instead of just a giant blob of defines.


- Joshua Colp


On July 16, 2014, 1:13 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3803/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 1:13 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Fixed the BUGBUG issues.
> 
> * Fixed bitfield type mismatches.  3 != (1 << 3)
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/main/format_compatibility.c 418753 
>   /team/group/media_formats-reviewed-trunk/include/asterisk/format_compatibility.h 418753 
>   /team/group/media_formats-reviewed-trunk/codecs/codec_dahdi.c 418753 
> 
> Diff: https://reviewboard.asterisk.org/r/3803/diff/
> 
> 
> Testing
> -------
> 
> Since I don't have a transcoder card I can only compile it.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140716/4810faf4/attachment.html>