[asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2
rmudgett
reviewboard at asterisk.org
Sun Jul 13 19:10:51 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12612
-----------------------------------------------------------
/trunk/channels/dahdi/bridge_native_dahdi.c
<https://reviewboard.asterisk.org/r/3758/#comment22893>
This should be removed in v12 also as the include is not needed there either. I don't know why it is including it.
Maybe I intended to explicitly include astobj2.h instead of astobj.h there. Unfortunately, that memory has been overwritten in my brain. :)
/trunk/include/asterisk/smdi.h
<https://reviewboard.asterisk.org/r/3758/#comment22894>
There should be a define for the 80.
/trunk/include/asterisk/smdi.h
<https://reviewboard.asterisk.org/r/3758/#comment22895>
There should be a define for the 80.
/trunk/res/res_smdi.c
<https://reviewboard.asterisk.org/r/3758/#comment22896>
Use the template functions from the Asterisk wiki. The OBJ_SEARCH_KEY and OBJ_SEARCH_OBJECT are enum values for a multi bit field in the flags parameter.
/trunk/res/res_smdi.c
<https://reviewboard.asterisk.org/r/3758/#comment22897>
Use ao2_container_alloc_list() instead of expressing it as a degenerate hash container.
/trunk/res/res_smdi.c
<https://reviewboard.asterisk.org/r/3758/#comment22898>
Use ao2_container_alloc_list() instead of expressing it as a degenerate hash container.
- rmudgett
On July 12, 2014, 6:38 p.m., Corey Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> -----------------------------------------------------------
>
> (Updated July 12, 2014, 6:38 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This code converts res_smdi to use astobj2.
>
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, ast_smdi_mwi_message destructor.
>
> The putback methods were unused and difficult to reimplement using ao2_containers.
>
> Includes for astobj.h are removed everywhere it's possible. The only remaining users are netsock.c (deprecated) and chan_sip (to be updated in a separate review).
>
>
> Diffs
> -----
>
> /trunk/res/res_smdi.c 418436
> /trunk/include/asterisk/smdi.h 418436
> /trunk/channels/sig_analog.c 418436
> /trunk/channels/dahdi/bridge_native_dahdi.c 418436
> /trunk/channels/chan_motif.c 418436
> /trunk/channels/chan_dahdi.c 418436
> /trunk/apps/app_voicemail.c 418436
>
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
>
>
> Testing
> -------
>
> Compile only (I do not have SMDI hardware).
>
>
> Thanks,
>
> Corey Farrell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140714/36fa6e37/attachment.html>
More information about the asterisk-dev
mailing list