[asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3765/#review12599
-----------------------------------------------------------



/trunk/main/astobj2.c
<https://reviewboard.asterisk.org/r/3765/#comment22886>

    Please add 'return -1;' after the assert.  We want this procedure to give up here even if DO_CRASH isn't enabled.


- Corey Farrell


On July 12, 2014, 11:49 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3765/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 11:49 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> On an invalid refcount, rather than just log the message and continue executing normally, provide a backtrace and an assert to stop on DO_CRASH.  This can help to catch the first case of an invalid refcount rather than being distracted from the problem with a flurry additional logs from other threads encountering already mangled data.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/astobj2.c 418447 
> 
> Diff: https://reviewboard.asterisk.org/r/3765/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140713/f3f2b50d/attachment.html>