[asterisk-dev] [Code Review] 3738: main/frame: Only unref formats on non-static frames

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3738/#review12546
-----------------------------------------------------------


Can you include removal of the ao2_bump from codecs/ex_*.h and include/asterisk/slin.h with this change?  I know other static bumps will have to be removed, but these happen during startup and I believe will cause all format's to leak refs.

- Corey Farrell


On July 10, 2014, 1:43 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3738/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 1:43 p.m.)
> 
> 
> Review request for Asterisk Developers, Corey Farrell, Joshua Colp, and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23960
>     https://issues.asterisk.org/jira/browse/ASTERISK-23960
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The format on the frame was being unreffed on static frames that had not bumped the ref resulting in a crash when compiled with the DO_CRASH flag due to the refcount on the format going negative.
> 
> 
> Diffs
> -----
> 
>   team/group/media_formats-reviewed-trunk/main/frame.c 418253 
> 
> Diff: https://reviewboard.asterisk.org/r/3738/diff/
> 
> 
> Testing
> -------
> 
> Ensured that the crash was resolved.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140710/383624f7/attachment.html>