[asterisk-dev] [Code Review] 3171: testsuite: autobahn 0.8.0 has moved websocket
Mark Michelson
reviewboard at asterisk.org
Fri Jan 31 16:41:13 CST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3171/#review10740
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Michelson
On Jan. 31, 2014, 10:24 p.m., Scott Griepentrog wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3171/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 10:24 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: testsuite
>
>
> Description
> -------
>
> Ran into an issue with a new installation while trying to run rest_api test originate:
>
> from autobahn.websocket import WebSocketClientFactory, \
> ImportError: cannot import name WebSocketClientFactory
>
> The websocket.py has been moved into the twisted subdir in autobahn 0.8.0.
>
> This change catches that failing import and retries in the new location.
>
> As an additional note: upon receiving "ImportError: cannot import name MsgPackSerializer" I discovered this was a bug in the earlier release of 0.8.0 fixed here https://github.com/tavendo/AutobahnPython/issues/188 and should be corrected by reinstalling autobahn or installing from the version on github.
>
>
> Diffs
> -----
>
> /asterisk/trunk/lib/python/asterisk/ari.py 4634
>
> Diff: https://reviewboard.asterisk.org/r/3171/diff/
>
>
> Testing
> -------
>
> Test tests/rest_api/channels/originate runs successfully after this change.
>
>
> Thanks,
>
> Scott Griepentrog
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140131/489cd614/attachment.html>
More information about the asterisk-dev
mailing list