[asterisk-dev] [Code Review] 3164: res_pjsip_mwi: Subscribe fails when missing aor name

Kevin Harwell reviewboard at asterisk.org
Fri Jan 31 16:09:20 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3164/
-----------------------------------------------------------

(Updated Jan. 31, 2014, 4:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Bugs: ASTERISK-23072
    https://issues.asterisk.org/jira/browse/ASTERISK-23072


Repository: Asterisk


Description
-------

When subscribing to MWI (res_pjsip_mwi) and the sip uri did not contain a name (ex: sip:<ip address>) then the subscription would fail since it would be unable to locate an associated aor.  This patch makes it so that when a subscribe comes with no aor name then it will subscribe to all aors on the located endpoint.


Diffs
-----

  branches/12/res/res_pjsip_mwi.c 406638 

Diff: https://reviewboard.asterisk.org/r/3164/diff/


Testing
-------

Some manual testing.  Set up an endpoint with two aors with two different mailboxes.  Made sure there were some messages waiting and then issued a subscribe without an aor name in the sip uri.  Noted the resulting notify had the correct number of new messages waiting.

Also setup a similar scenario in the testsuite: https://reviewboard.asterisk.org/r/3165/


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140131/1ec3f35a/attachment.html>


More information about the asterisk-dev mailing list