[asterisk-dev] [Code Review] 3153: testsuite: Dial tests for mid-call events, after-bridge actions, and peer h extension

[Matt Jordan]

> On Jan. 30, 2014, 3:48 p.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/test-config.yaml, lines 43-50
> > <https://reviewboard.asterisk.org/r/3153/diff/1/?file=53098#file53098line43>
> >
> >     I suggest adding a channel field to this userevent and ensuring it's the dialed channel that is executing the userevent and not the calling channel.

Added


> On Jan. 30, 2014, 3:48 p.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/test-config.yaml, lines 35-42
> > <https://reviewboard.asterisk.org/r/3153/diff/1/?file=53100#file53100line35>
> >
> >     Same suggestion here as with the previous test, except ensure it's the calling channel that causes the userevent to be sent.

Added


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3153/#review10731
-----------------------------------------------------------


On Jan. 24, 2014, 12:09 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3153/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 12:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23164
>     https://issues.asterisk.org/jira/browse/ASTERISK-23164
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Mid-call events, the 'h' extension, and moving channels around during/after a Dial operation currently play merry hell with CDRs. As it turned out, as I was fixing those problems I found a couple of other bugs in Dial, so I went ahead and wrote these tests. This includes:
> 
>  * Mid-call events (GoSub/Macro): ensure that we don't get extra CDR records; that the application is still Dial after dialplan execution in the final record; and that the dial status afterwards is the result of the GoSub/Macro evaluation
>  * After-bridge actions: This includes the F,G, and g option. Some of these are after-bridge, some prevent the bridge from happening in the first place. The tests verify that the correct dialplan actions take place, and for 12, that the expected CDR entries are created.
>  * 'h' extension execution of the peer. This should not only happen, but not create an extra CDR.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/dial/tests.yaml 4579 
>   /asterisk/trunk/tests/apps/dial/peer_h_exten/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/peer_h_exten/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/mid_call_events/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/action_post_answer/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/action_post_answer/party_transfer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/action_post_answer/party_transfer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3153/diff/
> 
> 
> Testing
> -------
> 
> Tests pass with modifications to be put up on a separate review.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140130/c879eaeb/attachment-0001.html>