[asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3148/
-----------------------------------------------------------

(Updated Jan. 30, 2014, 11:51 a.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed review comments.  Namely removed all the alembic changes except for the one directly pertaining to this issue.  The other changes were moved into another patch: https://reviewboard.asterisk.org/r/3167/


Bugs: ASTERISK-23038
    https://issues.asterisk.org/jira/browse/ASTERISK-23038


Repository: Asterisk


Description
-------

Added a "debug" configuration option for res_pjsip that when set to "yes" enables SIP messages to be logged.  It is specified under the "system" type.

Also updated the alembic 12.1 script to include this option as well as a few others that were missing.  Also updated the "_adding_extensions" script in order to make the "id" column on the table a primary key because mysql needed it to be as such.


Diffs (updated)
-----

  branches/12/res/res_pjsip_logger.c 406340 
  branches/12/res/res_pjsip/config_global.c 406340 
  branches/12/res/res_pjsip.c 406340 
  branches/12/include/asterisk/res_pjsip.h 406340 
  branches/12/contrib/ast-db-manage/config/versions/21e526ad3040_add_pjsip_debug_option.py PRE-CREATION 
  branches/12/configs/pjsip.conf.sample 406340 
  branches/12/UPGRADE.txt 406340 
  branches/12/CHANGES 406340 

Diff: https://reviewboard.asterisk.org/r/3148/diff/


Testing
-------

Set the "debug" option in the pjsip.conf file and observed SIP debug messages on the console.  Also, tested the modified alembic scripts against postgres and mysql database servers.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140130/17fda298/attachment.html>