[asterisk-dev] [Code Review] 3160: ChanSpy: Add ability to specify channel by uniqueid.

[rmudgett]

> On Jan. 28, 2014, 5:37 p.m., Jonathan Rose wrote:
> > So one quick question comes to mind...  Why does pickupchan simply scan by uniqueid if a channel couldn't be found while chanspy has to supply an argument to decide on the behavior?

The parameter to PickupChan is supposed to be a single channel name.  The fallback to searching by uniqueid is possible since we are still looking for a single channel.

The chanprefix parameter to ChanSpy is supposed to be the channel technology such as "SIP", "DAHDI", or "Agent" so you will get a group of channels to iterate over and the first matching channel is initially spied upon.  Dialed digits are applied to the chanprefix to make a channel name so you can jump to a specific channel.  So if chanprefix is "SIP" then dialed digits are appended to generate SIP/200.  You could supply SIP/200 and just be able to monitor SIP/200 but the code doesn't disable the channel generation code for dialed digits.  The new 'u' option disables that code as it makes no sense for "/200" to be appended to a uniqueid.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3160/#review10711
-----------------------------------------------------------


On Jan. 27, 2014, 3:11 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3160/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 3:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AFS-42
>     https://issues.asterisk.org/jira/browse/AFS-42
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> ChanSpy now accepts a channel uniqueid or a fully specified channel name as the chanprefix parameter if the 'u' option is specified.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_chanspy.c 406647 
>   /trunk/CHANGES 406647 
> 
> Diff: https://reviewboard.asterisk.org/r/3160/diff/
> 
> 
> Testing
> -------
> 
> Requested to spy on a channel using a fully specified channel name and also by uniqueid.
> Spying is successful if the channel exists.
> Spying fails if the channel does not exist.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140129/badad067/attachment.html>