[asterisk-dev] [Code Review] 3159: Allow nested #includes in extconfig.conf

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3159/
-----------------------------------------------------------

(Updated Jan. 27, 2014, 8:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers and Paul Belanger.


Bugs: ASTERISK-17837
    https://issues.asterisk.org/jira/browse/ASTERISK-17837


Repository: Asterisk


Description
-------

extconfig.conf was hard-coded to not allow nested includes for some reason.  The code has been this way since a patch was merged for ASTERISK-3333 (revision 4889), which was a significant update to this code ("Merge config updates").

I can't figure out any good reason why this should be limited.  This patch just removes the limit and uses the default nesting depth limit.


Diffs
-----

  /branches/1.8/main/config.c 406640 

Diff: https://reviewboard.asterisk.org/r/3159/diff/


Testing
-------

Created some nested includes in extconfig.conf.  Confirmed error before the patch and loading fine afterwards.


Thanks,

Russell Bryant

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140127/438f51f4/attachment.html>