[asterisk-dev] [Code Review] 3139: chan_pjsip: Test that all configured codecs are present in INVITE when sending

Mark Michelson reviewboard at asterisk.org
Fri Jan 24 15:52:55 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3139/#review10696
-----------------------------------------------------------

Ship it!



/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/requested_capabilities/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3139/#comment20195>

    These extensions aren't used, so you can remove them.


- Mark Michelson


On Jan. 18, 2014, 5:13 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3139/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2014, 5:13 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23082
>     https://issues.asterisk.org/jira/browse/ASTERISK-23082
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test confirms that all configured codecs are present in outgoing SDP when sending an INVITE, even if the core requests a specific codec.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/tests.yaml 4574 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/requested_capabilities/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/requested_capabilities/configs/ast3/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/requested_capabilities/configs/ast3/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/requested_capabilities/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/requested_capabilities/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/requested_capabilities/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/requested_capabilities/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3139/diff/
> 
> 
> Testing
> -------
> 
> Ran test. Without patch that fixes issue it failed, with patch it passes.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140124/9f229fd7/attachment.html>


More information about the asterisk-dev mailing list