[asterisk-dev] [Code Review] 3141: res_config_pgsql: Make sure PQClear is used for all PGResults

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3141/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 3:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers and Mark Michelson.


Repository: Asterisk


Description
-------

Updates most PGResult setting to use RAII_VAR and uses PQCLEAR as the cleanup function. I checked the PGSQL library source and this function is NULL safe so it doesn't appear to need a wrapper.

There was one location previously which had a PGResult being set without any call to PQClear.


Diffs
-----

  /branches/1.8/res/res_config_pgsql.c 405858 

Diff: https://reviewboard.asterisk.org/r/3141/diff/


Testing
-------

Made Asterisk use res_config_pgsql to perform some queries for queues and queue members.  Made sure it didn't crash.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140124/ad80d0f3/attachment.html>