[asterisk-dev] [Code Review] 3152: testsuite: Add a test for SQLite3 backend and custom CDR entries

Matt Jordan reviewboard at asterisk.org
Fri Jan 24 14:16:58 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3152/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 2:16 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Mark's finding.


Bugs: ASTERISK-23162
    https://issues.asterisk.org/jira/browse/ASTERISK-23162


Repository: testsuite


Description
-------

A user reported that, in Asterisk 12, the SQLite3 CDR backend was not recording any values. This prompted me to write a test to see if I could (a) reproduce the problem and (b) have a test that verified custom CDR values (which we don't currently test for, as our CDR CSV library is tied to the default expected columns). While I wasn't able to reproduce the issue reporter's problem, this was still a useful test... so here it is.

This test checks for the following:
 * That a sqlite3 CDR backend generates the expected records
 * That using the CDR function results in custom values being recorded
 * That the userfield values from channels are concatenated during a bridge operation
 * Some other minor, interesting behaviour 


Diffs (updated)
-----

  /asterisk/trunk/tests/cdr/sqlite3/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/cdr/sqlite3/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/cdr/sqlite3/configs/ast1/cdr_sqlite3_custom.conf PRE-CREATION 
  /asterisk/trunk/tests/cdr/sqlite3/configs/ast1/cdr.conf PRE-CREATION 
  /asterisk/trunk/tests/cdr/sqlite3/cdr_sqlite3.py PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3152/diff/


Testing
-------

It (mostly) passes with the latest in 12. The 'h' extension will currently create an unwanted record, but a patch for that will be going up shortly.


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140124/b9ce9d07/attachment.html>


More information about the asterisk-dev mailing list