[asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3148/#review10685
-----------------------------------------------------------


Okay, so I see what you are saying. I just ran the scripts and they are broken.  So, with that in mind I think we need two changesets, one that fixes the current alembic migration paths.  And the seconds which adds your logic.

Lastly, this we need an automate testcase for this, as it is obvious this code was checked in broken from the start.

- Paul Belanger


On Jan. 24, 2014, 5:46 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3148/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 5:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23038
>     https://issues.asterisk.org/jira/browse/ASTERISK-23038
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added a "debug" configuration option for res_pjsip that when set to "yes" enables SIP messages to be logged.  It is specified under the "system" type.
> 
> Also updated the alembic 12.1 script to include this option as well as a few others that were missing.  Also updated the "_adding_extensions" script in order to make the "id" column on the table a primary key because mysql needed it to be as such.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_logger.c 406340 
>   branches/12/res/res_pjsip/config_global.c 406340 
>   branches/12/res/res_pjsip.c 406340 
>   branches/12/include/asterisk/res_pjsip.h 406340 
>   branches/12/contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py 406340 
>   branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py 406340 
>   branches/12/configs/pjsip.conf.sample 406340 
> 
> Diff: https://reviewboard.asterisk.org/r/3148/diff/
> 
> 
> Testing
> -------
> 
> Set the "debug" option in the pjsip.conf file and observed SIP debug messages on the console.  Also, tested the modified alembic scripts against postgres and mysql database servers.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140124/0f43c92e/attachment.html>