[asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3148/#review10677
-----------------------------------------------------------


Note: My review is strictly on the C code and not the alembic stuff.

Is there a particular reason you placed this option in the "system" type instead of the "global" type? The difference between the two is that system options are not re-evaluated on a reload while global options are re-evaluated and applied on a reload. System options are typically reserved for options that affect the PJSIP runtime and therefore cannot be re-applied during a reload. However, this option seems like it should be able to be affected by a reload and should go in the global section instead of system.


branches/12/res/res_pjsip/config_system.c
<https://reviewboard.asterisk.org/r/3148/#comment20169>

    Josh may correct me on this, but since sorcery configs are immutable, you shouldn't need to duplicate cfg->debug here.



branches/12/res/res_pjsip/config_system.c
<https://reviewboard.asterisk.org/r/3148/#comment20168>

    Looks like you forgot to delete this before putting it up for review.



branches/12/res/res_pjsip_logger.c
<https://reviewboard.asterisk.org/r/3148/#comment20170>

    If you do switch to having debug configuration be in type=global, then you should add a sorcery observer to update the logging mode when configuration is reloaded.


- Mark Michelson


On Jan. 21, 2014, 11:01 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3148/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 11:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23038
>     https://issues.asterisk.org/jira/browse/ASTERISK-23038
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added a "debug" configuration option for res_pjsip that when set to "yes" enables SIP messages to be logged.  It is specified under the "system" type.
> 
> Also updated the alembic 12.1 script to include this option as well as a few others that were missing.  Also updated the "_adding_extensions" script in order to make the "id" column on the table a primary key because mysql needed it to be as such.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_logger.c 405906 
>   branches/12/res/res_pjsip/config_system.c 405906 
>   branches/12/res/res_pjsip.c 405906 
>   branches/12/include/asterisk/res_pjsip.h 405906 
>   branches/12/contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py 405906 
>   branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py 405906 
>   branches/12/configs/pjsip.conf.sample 405906 
> 
> Diff: https://reviewboard.asterisk.org/r/3148/diff/
> 
> 
> Testing
> -------
> 
> Set the "debug" option in the pjsip.conf file and observed SIP debug messages on the console.  Also, tested the modified alembic scripts against postgres and mysql database servers.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140124/e96ad58e/attachment-0001.html>