[asterisk-dev] [Code Review] 3142: Thread Debugging: Add LWP to core show locks output

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3142/#review10670
-----------------------------------------------------------



/trunk/main/utils.c
<https://reviewboard.asterisk.org/r/3142/#comment20159>

    Group this with the num_locks member to reduce potential padding.



/trunk/main/utils.c
<https://reviewboard.asterisk.org/r/3142/#comment20161>

    At the same time you could move line_num to times_locked to reduce padding.



/trunk/main/utils.c
<https://reviewboard.asterisk.org/r/3142/#comment20160>

    Maybe output this way:
    ...Thread ID: 0x%lx/%d (%s)
    or
    ...Thread ID: 0x%lx LWP:%d (%s)


- rmudgett


On Jan. 20, 2014, 11:46 a.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3142/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2014, 11:46 a.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This will add the LWP to core show locks output if it is available. (the function that gets this works differently depending on the operating system and not all of them are supported).
> 
> 
> Diffs
> -----
> 
>   /trunk/main/utils.c 405761 
>   /trunk/CHANGES 405761 
> 
> Diff: https://reviewboard.asterisk.org/r/3142/diff/
> 
> 
> Testing
> -------
> 
> I only tested this on Linux, but I created a deadlock scenario artificially and then checked core show locks output to see if the LWP was there.  It was.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140123/74b67843/attachment.html>