[asterisk-dev] [Code Review] 3144: Protect manager data structures during shutdown.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3144/
-----------------------------------------------------------

(Updated Jan. 21, 2014, 11:34 a.m.)


Review request for Asterisk Developers.


Changes
-------

Reverted over-eager optimization attempt pointed out by feedback.


Bugs: AST-1242
    https://issues.asterisk.org/jira/browse/AST-1242


Repository: Asterisk


Description
-------

Occasionally, the manager module would get an "INTERNAL_OBJ: bad magic number" error on a "core restart gracefully" command if an AMI connection is established.

* Added ao2_global_obj protection to the sessions global container.

* Fixed the order of unreferencing a session object in session_destroy().

* Removed unnecessary container traversals of the white/black filters during session_destructor().


Diffs (updated)
-----

  /branches/11/main/manager.c 406034 

Diff: https://reviewboard.asterisk.org/r/3144/diff/


Testing
-------

Since I was not able to reprocuce the INTERNAL_OBJ error reported, I just tested to see that things still worked.
* The CLI "manager show connected" still works.
* The system can still restart and shutdown.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140121/6ce3b96c/attachment.html>