[asterisk-dev] [Code Review] 3134: pbx.c: avoid segfault on uninitialized time values

[Scott Griepentrog]

> On Jan. 17, 2014, 6:46 p.m., rmudgett wrote:
> > Only the corryfarrel patch is needed.  The other patch is not complete and is supurfluous.

You're right, I should have caught that.


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3134/#review10633
-----------------------------------------------------------


On Jan. 17, 2014, 12:51 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3134/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 12:51 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22861
>     https://issues.asterisk.org/jira/browse/ASTERISK-22861
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Merge of two patches - one from sebmurray and another from coreyfarrell - related to eliminating referencing uninitialized structures in pbx.c.  Avoids destroying timing unless it was successfully built, and leaking an uninitialized timezone.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/utils/extconf.c 405842 
>   /branches/1.8/main/pbx.c 405842 
> 
> Diff: https://reviewboard.asterisk.org/r/3134/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140120/80ddad4a/attachment-0001.html>