[asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

[Jonathan Rose]

> On Jan. 16, 2014, 10:40 a.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/rest_api/mailbox/baseline/mailbox_baseline.py, lines 77-80
> > <https://reviewboard.asterisk.org/r/3118/diff/2/?file=51376#file51376line77>
> >
> >     What happens if this is removed?
> 
> Jonathan Rose wrote:
>     The channel never goes away, StasisEnd never happens, reactor times out, and the test fails.
>     
>     ARI tests all seem to be designed in this manner... a channel entering Stasis triggers the start of the test and it leaving Stasis triggers the end of the test. It seems a little unnecessary for mailbox tests since they don't really involve channels, but I haven't really figured out a good way around it.

Updated comment to:

    # While this test doesn't actually use the channel for any of the ARI
    # operations that it does, its presence is necessary for triggering
    # the test and removing it is necessary for completing the test.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3118/#review10600
-----------------------------------------------------------


On Jan. 9, 2014, 5:40 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3118/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 5:40 p.m.)
> 
> 
> Review request for Asterisk Developers, Kevin Harwell, Matt Jordan, and Mark Michelson.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Somewhat similar to kharwell's device state tests.
> 
> ARI is used to:
> * create a couple mailboxes
> * confirm that GET can be used to get one mailbox and that it matches expectations
> * confirm that GET can be used to get all the mailboxes and that they match expectations
> * modify one mailbox
> * delete another mailbox
> * verify that the mailbox that was deleted is no longer obtained by get
> * verify that the mailbox that was modified has the modified state.
> 
> The nature of these operations is simple enough that this seemed appropriate to be a single test.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/tests.yaml 4545 
>   /asterisk/trunk/tests/rest_api/mailbox/baseline/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/mailbox/baseline/mailbox_baseline.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/mailbox/baseline/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3118/diff/
> 
> 
> Testing
> -------
> 
> Ran the test. Varied the expectations from the results to cause failures for each substep.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140116/2796cff1/attachment.html>