[asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

[Mark Michelson]

> On Jan. 16, 2014, 3:10 p.m., Joshua Colp wrote:
> > branches/12/res/res_pjsip_endpoint_identifier_ip.c, lines 285-287
> > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51197#file51197line285>
> >
> >     I'm cracking down on gratuitous RAII_VAR usage these days.

Actually, this use of RAII_VAR wouldn't be gratuitous if potential allocation failures were checked for. In that case, there would be several return paths requiring unreffing the containers.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3104/#review10595
-----------------------------------------------------------


On Jan. 6, 2014, 9:49 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3104/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 9:49 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds identify, transport and registration support to the CLI.
> Creates 3 additional callbacks, one for an iterator, one for a comparator and one for a container.  This eliminates the link dependency from higher level modules to lower level ones.
> Eliminates duplicate sorting.
> Cleans up output formatting.
> Pushes cli registration down to the implementing source file.
> Adds several ast_sip_destroy_sorcery functions to complement existing ast_sip_sorcery_initialize functions.  The destroy functions unregister cli commands and cli formatters.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_outbound_registration.c 405000 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 405000 
>   branches/12/res/res_pjsip/pjsip_configuration.c 405000 
>   branches/12/res/res_pjsip/pjsip_cli.c 405000 
>   branches/12/res/res_pjsip/location.c 405000 
>   branches/12/res/res_pjsip/config_transport.c 405000 
>   branches/12/res/res_pjsip/config_auth.c 405000 
>   branches/12/include/asterisk/res_pjsip_cli.h 405000 
>   branches/12/include/asterisk/res_pjsip.h 405000 
> 
> Diff: https://reviewboard.asterisk.org/r/3104/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140116/36e36a3e/attachment-0001.html>