[asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

[rmudgett]

> On Jan. 13, 2014, 4:24 p.m., Matt Jordan wrote:
> > /branches/12/main/http.c, lines 804-805
> > <https://reviewboard.asterisk.org/r/3125/diff/1/?file=52887#file52887line804>
> >
> >     You don't need the while(1) here, as you aren't breaking out of the block scope that it provides.

The curly is in the wrong place per guidelines.
Also I know some static checkers can complain of an always true while loop where they won't if you use for (;;)


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/#review10583
-----------------------------------------------------------


On Jan. 13, 2014, 4:09 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3125/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 4:09 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23068
>     https://issues.asterisk.org/jira/browse/ASTERISK-23068
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Implements support for HTTP chunked mode Transfer-Encoding in JSON and Form (post vars) body content.  Relocated code from ast_http_get_json() and ast_http_get_post_vars() that reads content from stream into new function ast_http_get_contents(), and added support for reading and decoding chunked mode transfers.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/http.c 405282 
>   /branches/12/include/asterisk/http.h 405282 
> 
> Diff: https://reviewboard.asterisk.org/r/3125/diff/
> 
> 
> Testing
> -------
> 
> Testsuite test rest_api/chunked_transfer added (see https://reviewboard.asterisk.org/r/3126/) to insure correct operation of chunked and regular mode.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140113/5569c4ac/attachment-0001.html>