[asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

[Jonathan Rose]

> On Jan. 9, 2014, 7:38 p.m., Paul Belanger wrote:
> > /branches/12/rest-api/api-docs/mailboxes.json, line 34
> > <https://reviewboard.asterisk.org/r/3117/diff/2/?file=51373#file51373line34>
> >
> >     punctuation on the sentence.
> >
> 
> Mark Michelson wrote:
>     This isn't a sentence. What punctuation do you expect?

I'm guessing a period because 'punctuation on the sentence' isn't a sentence either. I assumed he was doing that to point out what he meant.
Checking through existing documentation whether or not this is normal is kind of all over the board.
Some descriptions that are fragments have periods. Some descriptions that are fragments don't. Some descriptions that are full sentences
don't have periods and some don't.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3117/#review10556
-----------------------------------------------------------


On Jan. 9, 2014, 5:38 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3117/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 5:38 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds the ability to interface with res_external_mwi via AMI.  The following commands are implemented:
> 
> PUT mailboxes/mailboxName
>     modifies mailbox state and implicitly creates new mailboxes
> 
> GET mailboxes/mailboxName
>     retrieves a JSON representation of a single mailbox if it exists
> 
> GET mailboxes
>     retrieves a JSON array of all mailboxes
> 
> DELETE mailbox/mailboxName
>     deletes a mailbox
> 
> Thanks to Richard's external MWI work, this is actually a very simple system.
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/resources.json 405265 
>   /branches/12/rest-api/api-docs/mailboxes.json PRE-CREATION 
>   /branches/12/res/res_stasis_mailbox.exports.in PRE-CREATION 
>   /branches/12/res/res_stasis_mailbox.c PRE-CREATION 
>   /branches/12/res/res_ari_mailboxes.c PRE-CREATION 
>   /branches/12/res/ari/resource_mailboxes.c PRE-CREATION 
>   /branches/12/res/ari/resource_mailboxes.h PRE-CREATION 
>   /branches/12/res/ari/ari_model_validators.c 405265 
>   /branches/12/res/ari/ari_model_validators.h 405265 
>   /branches/12/res/ari.make 405265 
>   /branches/12/include/asterisk/stasis_app_mailbox.h PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3117/diff/
> 
> 
> Testing
> -------
> 
> Tested unloads and reloads of the res_stasis_mailboxes module with res_mwi_external loaded and unloaded
> Tested how commands respond from resource_mailboxes when res_stasis_mailboxes isn't loaded
> Tested each of the commands with numerous parameters
> Created testsuite test in https://reviewboard.asterisk.org/r/3118/ which confirms basic operation of all the new ARI functions.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140110/9f091ab4/attachment-0001.html>