[asterisk-dev] [Code Review] 3116: chan_sip: eliminate channel state down prior to hangup

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3116/
-----------------------------------------------------------

(Updated Jan. 10, 2014, 10:49 a.m.)


Review request for Asterisk Developers.


Changes
-------

Per wdoekes suggestion, moved lock/unlock inside the conditional.


Bugs: ASTERISK-23010
    https://issues.asterisk.org/jira/browse/ASTERISK-23010


Repository: Asterisk


Description
-------

Setting the channel state to down is not done anywhere in chan_sip except handle_invite_replaces() after masquerading, and can interfere with the subsequent hangup of the channel.  Removing it appears to make sense, and causes no problems, although I was unable to observe a new BYE message in the packet trace of test sip_one_legged_transfer.


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 405265 

Diff: https://reviewboard.asterisk.org/r/3116/diff/


Testing
-------

Ran all SIP tests in testsuite before and after, no new failures.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140110/ea6a8153/attachment.html>