[asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

[Joshua Colp]

> On Jan. 9, 2014, 7:19 p.m., Matt Jordan wrote:
> > /branches/12/res/res_pjsip_multihomed.c, lines 83-86
> > <https://reviewboard.asterisk.org/r/3102/diff/1/?file=51132#file51132line83>
> >
> >     If we don't have a multihomed transport and/or the transport hasn't changed, I'm not sure why we would need to continue processing here.

If you don't bind to each interface individually then you'll only have one transport, but the source address will be different. In this case you need to modify the message regardless.


> On Jan. 9, 2014, 7:19 p.m., Matt Jordan wrote:
> > /branches/12/res/res_pjsip_multihomed.c, line 97
> > <https://reviewboard.asterisk.org/r/3102/diff/1/?file=51132#file51132line97>
> >
> >     Based on the description of pjsip_tx_data_invalidate_msg, I would suspect we only need to call this once before returning. Do we need to call it for each change we make to tdata?

I purposely did it this way so invalidation only occurs if something has changed. I could set a variable and then if set do it at the end, but the internal cost of calling invalidate_msg a few times is tiny (it doesn't actually do anything really until something further down the module list gets the message).


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3102/#review10540
-----------------------------------------------------------


On Jan. 6, 2014, 8:06 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3102/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 8:06 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23020
>     https://issues.asterisk.org/jira/browse/ASTERISK-23020
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This module adds messaging rewriting for multihomed situations. When messages are sent out it determines what interface and transport the message is going out on. The IP address for this is then placed into the message.
> 
> I've written this as a module since it does add a bit of additional logic for outgoing messages.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_multihomed.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3102/diff/
> 
> 
> Testing
> -------
> 
> Sent and received calls/traffic in two configurations.
> 
> 1. Two transports each bound to specific interfaces
> 2. One transport bound to 0.0.0.0
> 
> Confirmed that the correct IP address for each interface went into the message.
> 
> Some additional testing by others would be nice.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140109/4098783e/attachment-0001.html>