[asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

[opticron]

> On Jan. 9, 2014, 10:36 a.m., Joshua Colp wrote:
> > /trunk/res/res_pjsip_path.c, lines 158-167
> > <https://reviewboard.asterisk.org/r/3050/diff/2/?file=51246#file51246line158>
> >
> >     Is there any reason you did this instead of calling ast_sip_set_outbound_proxy?
> >     
> >     Doing so would remove the requirement for path_get_string, remove path_dup, and get rid of your own generic string hdr creation.

The naming and documentation led me to believe that the current outbound proxy would be replaced which is apparently not the case. Fixed.


> On Jan. 9, 2014, 10:36 a.m., Joshua Colp wrote:
> > /trunk/res/res_pjsip_path.c, lines 205-215
> > <https://reviewboard.asterisk.org/r/3050/diff/2/?file=51246#file51246line205>
> >
> >     My same question applies here.

This grabs the same data as above, but inserts a Path header instead of a Route header.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3050/#review10533
-----------------------------------------------------------


On Jan. 6, 2014, 3:52 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3050/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 3:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21084
>     https://issues.asterisk.org/jira/browse/ASTERISK-21084
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds Path support to chan_pjsip in res_pjsip_path.c with minimal additions in res_pjsip_registrar.c to store the path and additions in res_pjsip_outbound_registration.c to enable advertisement of path support to registrars and intervening proxies.
> 
> Path information is stored on contacts and is enabled via Address of Record (AoRs) and Registration configuration sections.
> 
> While adding path support, it became necessary to be able to add SIP supplements that handled messages outside of sessions, so a framework for handling these types of hooks was added in parallel to the already-existing session supplements and several senders of out-of-dialog requests were refactored as a result.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip_t38.c 405005 
>   /trunk/res/res_pjsip_session.c 405005 
>   /trunk/res/res_pjsip_registrar.c 405005 
>   /trunk/res/res_pjsip_refer.c 405005 
>   /trunk/res/res_pjsip_path.c PRE-CREATION 
>   /trunk/res/res_pjsip_outbound_registration.c 405005 
>   /trunk/res/res_pjsip_notify.c 405005 
>   /trunk/res/res_pjsip_nat.c 405005 
>   /trunk/res/res_pjsip_mwi.c 405005 
>   /trunk/res/res_pjsip_messaging.c 405005 
>   /trunk/res/res_pjsip_header_funcs.c 405005 
>   /trunk/res/res_pjsip_diversion.c 405005 
>   /trunk/res/res_pjsip_caller_id.c 405005 
>   /trunk/res/res_pjsip/pjsip_options.c 405005 
>   /trunk/res/res_pjsip/pjsip_distributor.c 405005 
>   /trunk/res/res_pjsip/location.c 405005 
>   /trunk/res/res_pjsip.c 405005 
>   /trunk/include/asterisk/res_pjsip_session.h 405005 
>   /trunk/include/asterisk/res_pjsip.h 405005 
>   /trunk/channels/chan_pjsip.c 405005 
> 
> Diff: https://reviewboard.asterisk.org/r/3050/diff/
> 
> 
> Testing
> -------
> 
> This passes the tests covered by the review at https://reviewboard.asterisk.org/r/3051/
> 
> These tests were converted to work with chan_pjsip from their chan_sip counterparts.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140109/b4e60b31/attachment.html>