[asterisk-dev] [Code Review] 3113: PJSIP: Print "<unknown>" instead of a UUID for artificial PJSIP endpoints' account IDs in security events

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3113/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

I was doing a bit of testing regarding AMI security events with res_pjsip. I noticed that when dealing with an artificial endpoint, the ChallengeSent and ChallengeResponseFailed events printed a UUID for the account ID field. This is because the artificial endpoint is the relevant endpoint and its sorcery ID is a UUID. For the sake of security events, I think it's more user-friendly to print something more clear. I've chosen the string "<unknown>", but I'm open to other suggestions.

This review is made against Asterisk 12, but if this is something that feels more like a trunk-only change, I could make it there instead.


Diffs
-----

  /branches/12/res/res_pjsip/security_events.c 405131 

Diff: https://reviewboard.asterisk.org/r/3113/diff/


Testing
-------

Wrote a starpy script that printed out the security events as they were received. Confirmed that the account ID changed from a UUID to "<unknown>"


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140109/2220f806/attachment-0001.html>