[asterisk-dev] [Code Review] 3101: rasterisk needlessly prints the AST-2013-007 warning

Paul Belanger reviewboard at asterisk.org
Fri Jan 3 13:23:14 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3101/#review10517
-----------------------------------------------------------

Ship it!


Ship It!

- Paul Belanger


On Jan. 3, 2014, 7:14 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3101/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 7:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23084
>     https://issues.asterisk.org/jira/browse/ASTERISK-23084
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Even since the fixes of AST-2013-007, Asterisk prints the following warning on startup if the user decided to live dangerously:
> 
> Privilege escalation protection disabled!
> See https://wiki.asterisk.org/wiki/x/1gKfAQ for more details.
> 
> I believe that this warning is intended to be one-time and thus makes no sense when asterisk is run as a remote terminal. It certainly makes no sense when Asterisk is run to issue a remote command (asterisk -rx). This patch disables the warning on those two cases.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/asterisk.c 404783 
> 
> Diff: https://reviewboard.asterisk.org/r/3101/diff/
> 
> 
> Testing
> -------
> 
> Checked with asterisk 11
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140103/8350ecfc/attachment.html>


More information about the asterisk-dev mailing list