[asterisk-dev] [Code Review] 3094: res_pjsip_messaging: potential for field values in from/to headers to be missing

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3094/
-----------------------------------------------------------

(Updated Jan. 3, 2014, 11:17 a.m.)


Review request for Asterisk Developers.


Changes
-------

Made it so res_pjsip always sends out a 'sip:' uri as apposed to 'sips:'.  Also, the 'From' header now gets created as follows: 

1. With default values - user = GUID unless a 'from_user' is specified, domain = asterisk ip, unless a 'from_domain' is specified.
2. If a 'from' parameter has been specified in MessageSend then the values found there will overwrite the display name, user, and domain


Bugs: ASTERISK-22924
    https://issues.asterisk.org/jira/browse/ASTERISK-22924


Repository: Asterisk


Description
-------

Added in ability to specify display name format ("name" <sip:name at ipaddr:port>) for a given URI and made sure it was fully propagated to the outgoing message.  This mainly occurred when sending to a direct URI (using the default outbound endpoint).  MESSAGEs sent to/from a valid endpoint will use that endpoint's AOR/contact to fill in the appropriate information.


Diffs (updated)
-----

  branches/12/res/res_pjsip_messaging.c 404606 
  branches/12/res/res_pjsip.c 404606 

Diff: https://reviewboard.asterisk.org/r/3094/diff/


Testing
-------

Some manual testing and also ran the current testsuite tests that exists to make sure everything still worked as expected.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140103/481ff3f5/attachment.html>