[asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

[Joshua Colp]

> On Jan. 3, 2014, 9:24 a.m., schmidts wrote:
> > i have found a bug but i am not sure if this only depends on this patch or on pjsip itself. I have a subscribe sipp scenario which works fine with chan_sip but broke down pjsip completly. i have found that in my scenario i have a wrong format for the 200 response after the NOTIFY request, where the to and from header looked like this: "From: : <sip:...". This causes pjsip to stop reading incoming messages at all. When i fixed this error in my scenario this doesnt happens anymore but maybe this is an underlying bug we should mention.

PJSIP does message and header validation. In this case the From header was actually malformed, and it therefore rejected it before it even left the transport layer. ':' is a reserved character and has to be escaped or quoted. An example which passes validation: From: ":" <sip:..."


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3093/#review10512
-----------------------------------------------------------


On Dec. 25, 2013, 2:53 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3093/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2013, 2:53 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21443
>     https://issues.asterisk.org/jira/browse/ASTERISK-21443
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Some devices use the dialog-info+xml to get presence information about an extension. The attached change implements this but DOES NOT implement the "pickup ringing channel" functionality available on Snoms.
> 
> To facilitate this implementation I have also changed it so the subscription is passed to the body creation callback. This allows implementations to store state information on the subscription.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_pidf.c 404578 
>   /branches/12/res/res_pjsip_exten_state.c 404578 
>   /branches/12/res/res_pjsip_dialog_info.c PRE-CREATION 
>   /branches/12/include/asterisk/res_pjsip_exten_state.h 404578 
> 
> Diff: https://reviewboard.asterisk.org/r/3093/diff/
> 
> 
> Testing
> -------
> 
> Subscribed to an extension from a device that uses dialog-info+xml. Confirmed NOTIFY messages going out contain the expected content.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140103/76f39712/attachment.html>