[asterisk-dev] [Code Review] 3258: testsuite: eliminate sipp zombie

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3258/#review10957
-----------------------------------------------------------

Ship it!


Ship It!

- wdoekes


On Feb. 25, 2014, 4:26 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3258/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 4:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> While running the testsuite I noticed it would occasionally fail to start, complaining of being unable to kill sipp (code introduced svn r4677 and https://reviewboard.asterisk.org/r/3198/).  I tracked this back to an instance of sipp that was used to check the version number, and revised the method used to read the stdout per python manual "Warning Use communicate() rather than .stdin.write, .stdout.read or .stderr.read to avoid deadlocks due to any of the other OS pipe buffers filling up and blocking the child process.".  The version check process was then cleanly terminated before checking for sipp instances leftover from a previous test run via pidof sipp.
> 
> Another option as suggested is to use popen.wait() to clean up the zombie.  Patch updated to this method (simpler) and added similar fix to Asterisk version test.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/version.py 4735 
>   /asterisk/trunk/lib/python/asterisk/sippversion.py 4735 
> 
> Diff: https://reviewboard.asterisk.org/r/3258/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140226/19be4d19/attachment.html>