[asterisk-dev] [Code Review] 3263: Testsuite: Fix originate-cdr-disposition failure reporting
Corey Farrell
reviewboard at asterisk.org
Mon Feb 24 18:18:01 CST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3263/
-----------------------------------------------------------
Review request for Asterisk Developers and Matt Jordan.
Bugs: ASTERISK-23352
https://issues.asterisk.org/jira/browse/ASTERISK-23352
Repository: testsuite
Description
-------
The test-config.yaml for this test specifies ignore-originate-failure as 'yes' or 'no'. Both strings evaulate to True, causing all failures to be ignored.
tests/cdr/cdr-tests.py fails catch the exception thrown by Originate failures. All exception backtraces are shown, for excepted and unexpected failures. Additionally test_object.set_pass(False) is never run for unexpected failures, so success is incorrectly reported.
Diffs
-----
/asterisk/trunk/tests/cdr/originate-cdr-disposition/test-config.yaml 4730
/asterisk/trunk/tests/cdr/cdr-tests.py 4730
Diff: https://reviewboard.asterisk.org/r/3263/diff/
Testing
-------
Thanks,
Corey Farrell
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140225/4ec115c4/attachment.html>
More information about the asterisk-dev
mailing list