[asterisk-dev] [Code Review] 3236: chan_sip: do not send empty Route header
wdoekes
reviewboard at asterisk.org
Thu Feb 20 01:51:33 CST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3236/#review10911
-----------------------------------------------------------
Ship it!
While it is not real pretty, it is at least contained to a single small function.
- wdoekes
On Feb. 18, 2014, 9:46 p.m., Corey Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3236/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 9:46 p.m.)
>
>
> Review request for Asterisk Developers and wdoekes.
>
>
> Bugs: ASTERISK-23306
> https://issues.asterisk.org/jira/browse/ASTERISK-23306
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Prevent add_route from adding empty Route header.
>
>
> Diffs
> -----
>
> /trunk/channels/chan_sip.c 408296
>
> Diff: https://reviewboard.asterisk.org/r/3236/diff/
>
>
> Testing
> -------
>
> tests/channels/SIP/path, tests/channels/SIP/route, manual test of calls without Record-Route headers.
>
>
> Thanks,
>
> Corey Farrell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140220/4d12a5b2/attachment.html>
More information about the asterisk-dev
mailing list