[asterisk-dev] [Code Review] 3211: ARI: URI is case sensitive

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3211/
-----------------------------------------------------------

(Updated Feb. 14, 2014, 3:45 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Bugs: ASTERISK-23125
    https://issues.asterisk.org/jira/browse/ASTERISK-23125


Repository: Asterisk


Description
-------

URI's are supposed to be case sensitive, and traditionally all lower case for arbitrary path names.  However, the Asterisk convention of CAPS for technology names (SIP, PJSIP, LOCAL, etc) was causing a situation where certain ARI URI's would work in either case, and others not.

The use of all lower case in ARI URI's, including technology names, is desired.  This patch causes TECH names to be uppercase before lookup in stasis.

Note that I have chosen to not enforce lower case on the /ari prefix portion of the URI at this time, in case it would cause something else to break.

Reference for asterisk-app-dev list discussion: http://lists.digium.com/pipermail/asterisk-app-dev/2014-January/000321.html


Diffs
-----

  /branches/12/main/stasis_endpoints.c 407957 

Diff: https://reviewboard.asterisk.org/r/3211/diff/


Testing
-------

Checked that /ari/endpoints/PJSIP/{endpoint} and /ari/endpoints/pjsip/{endpoint} both work.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140214/7c29bc7a/attachment.html>