[asterisk-dev] [Code Review] 3132: Test for allow=all sdp issue

opticron reviewboard at asterisk.org
Wed Feb 12 10:36:27 CST 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3132/#review10858
-----------------------------------------------------------



/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/configs/ast1/pjsip.conf
<https://reviewboard.asterisk.org/r/3132/#comment20472>

    This is not an allow=all configuration as mentioned in the description.



/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml
<https://reviewboard.asterisk.org/r/3132/#comment20467>

    You can't reuse variables for primary ereg matches. If you do, you'll miss match failures in anything but the first usage because of the way that ereg creates and reuses variables.



/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml
<https://reviewboard.asterisk.org/r/3132/#comment20466>

    This is what the Reference tag is meant for.
    For example:
    <Reference variables="1,2,3" />
    
    This should be placed after the recv closing tag.



/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml
<https://reviewboard.asterisk.org/r/3132/#comment20469>

    Idem.



/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml
<https://reviewboard.asterisk.org/r/3132/#comment20468>

    Red blob.



/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml
<https://reviewboard.asterisk.org/r/3132/#comment20470>

    Idem.



/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml
<https://reviewboard.asterisk.org/r/3132/#comment20471>

    Idem.


These comments apply to the other instances of this test as well.

- opticron


On Jan. 28, 2014, 1:19 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3132/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 1:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23018
>     https://issues.asterisk.org/jira/browse/ASTERISK-23018
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is just a copy of tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host with allow=all instead of allow=ulaw.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 4563 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3132/diff/
> 
> 
> Testing
> -------
> 
> It correctly fails without the 3131 code implemented.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140212/299acc12/attachment-0001.html>

More information about the asterisk-dev mailing list